From bcc936716ba48b0640cc9d25e66b752e23275294 Mon Sep 17 00:00:00 2001 From: Javier Julio Date: Fri, 6 Oct 2023 18:51:11 -0400 Subject: [PATCH] Remove upper bound limit from our dependencies All that was needed to support Rails 7 in this gem was to update the gemspec. This means that even in the most likely release to break anything, a major release, we didn't needed to worry about breaking this gem. This upper bound is just creating unnecessary work for the maintainers of this gem, which would need to release it without any code change, and the users, which need to open issues asking for new releases. Let's allow our users to try any version of our dependencies and report real issues if they find them, and save everyone's time just removing the upper bound. --- Gemfile.lock | 4 ++-- arbre.gemspec | 4 ++-- gemfiles/rails_61/Gemfile.lock | 4 ++-- spec/gemspec_spec.rb | 4 ---- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index ec054ba5..e53506c8 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,8 +2,8 @@ PATH remote: . specs: arbre (1.6.0) - activesupport (>= 3.0.0, < 7.1) - ruby2_keywords (>= 0.0.2, < 1.0) + activesupport (>= 3.0.0) + ruby2_keywords (>= 0.0.2) GEM remote: http://rubygems.org/ diff --git a/arbre.gemspec b/arbre.gemspec index d18ccbcf..987b8735 100644 --- a/arbre.gemspec +++ b/arbre.gemspec @@ -24,6 +24,6 @@ Gem::Specification.new do |s| s.required_ruby_version = '>= 2.7' - s.add_dependency("activesupport", ">= 3.0.0", "< 7.1") - s.add_dependency("ruby2_keywords", ">= 0.0.2", "< 1.0") + s.add_dependency("activesupport", ">= 3.0.0") + s.add_dependency("ruby2_keywords", ">= 0.0.2") end diff --git a/gemfiles/rails_61/Gemfile.lock b/gemfiles/rails_61/Gemfile.lock index 62b40c17..9c24a320 100644 --- a/gemfiles/rails_61/Gemfile.lock +++ b/gemfiles/rails_61/Gemfile.lock @@ -2,8 +2,8 @@ PATH remote: ../.. specs: arbre (1.6.0) - activesupport (>= 3.0.0, < 7.1) - ruby2_keywords (>= 0.0.2, < 1.0) + activesupport (>= 3.0.0) + ruby2_keywords (>= 0.0.2) GEM remote: http://rubygems.org/ diff --git a/spec/gemspec_spec.rb b/spec/gemspec_spec.rb index aacab6b2..fed23a8c 100644 --- a/spec/gemspec_spec.rb +++ b/spec/gemspec_spec.rb @@ -14,10 +14,6 @@ end end - it "has no warnings" do - expect(build[1]).not_to include("WARNING") - end - it "succeeds" do expect(build[2]).to be_success end