make Element#inspect behave correctly in Ruby 2.0
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of ruby/ruby@fd7dc23d281f, `Kernel#inspect` no longer uses `to_s` if it's defined. This means that if `Element#inspect` is called, you'll currently get every instance variable printed out instead of the expected HTML.
seanlinsley
added a commit
that referenced
this pull request
Nov 13, 2013
make `Element#inspect` behave correctly in Ruby 2.0
|
Wooo!!! 💚 |
seanlinsley
added a commit
to activeadmin/activeadmin
that referenced
this pull request
Nov 28, 2013
also require latest Arbre to work around activeadmin/arbre#16
This was referenced Apr 6, 2014
|
Please release a new gem that contains this fix. The 1.0.1 that's up is from 2012. |
|
+1 for gem release |
|
bumping for gem release (last is from almost 2yrs ago, as noted by @Marius0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of ruby/ruby@fd7dc23d281f,
Kernel#inspectno longer usesto_sif it's defined.This means that if
Element#inspectis called, you'll currently get every instancevariable printed out instead of the expected HTML.
This is causing serious issues for Active Admin when combined with
better_errors: activeadmin/activeadmin#2434Other references: