You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you 🙇♀ for wanting to create an issue in this repository. Before you do, please ensure you are filing the issue in the right place. Issues should only be opened on if the issue relates to code in this repository.
If you are having an issue or question about GitHub Actions then please contact customer support
If your issue is relevant to this repository, please include the information below:
Describe the enhancement
When pulling in @actions/glob (an 89KB package), it pulls in @actions/core (91KB package), fair enough. But... @actions/core depends on @actions/http-client, which has a 1.4MB install size due to pulling in Undici—which is already bundled in Node (but not all of it's exposed, so you do need the duplicate)!
I think it'd be reasonable to move getIDToken() to an @actions/oidc package to cut down on the size by 1.4MB, a >13x improvement (and switching to picomatch would also shave another 155B (~3x difference in size between the two), though it be might be too breaking?).
In comparison, tinyglobby (and all dependencies) is only 155KB, ~11x smaller than @actions/glob (and dependencies).
To both improve startup speed and the actions development experience, I'd say it'd make sense to shuffle some of this around.
Code Snippet
n/a
Additional information
Related: #1770 should allow tree shaking away these dependencies, although plenty of packages directly include node_modules (no build step) and the development install would still be large.
Node.js might expose ProxyAgent soon, allowing droppage of undici, once actions is bumped to 24 or whenever: nodejs/node#43187.
Codecov PR: codecov/codecov-action#1524 (I used tinyglobby instead, but they ended up switching to bash)
The text was updated successfully, but these errors were encountered:
Thank you 🙇♀ for wanting to create an issue in this repository. Before you do, please ensure you are filing the issue in the right place. Issues should only be opened on if the issue relates to code in this repository.
If your issue is relevant to this repository, please include the information below:
Describe the enhancement
When pulling in
@actions/glob
(an 89KB package), it pulls in@actions/core
(91KB package), fair enough. But...@actions/core
depends on@actions/http-client
, which has a 1.4MB install size due to pulling in Undici—which is already bundled in Node (but not all of it's exposed, so you do need the duplicate)!I think it'd be reasonable to move
getIDToken()
to an@actions/oidc
package to cut down on the size by 1.4MB, a >13x improvement (and switching to picomatch would also shave another 155B (~3x difference in size between the two), though it be might be too breaking?).In comparison,
tinyglobby
(and all dependencies) is only 155KB, ~11x smaller than@actions/glob
(and dependencies).To both improve startup speed and the actions development experience, I'd say it'd make sense to shuffle some of this around.
Code Snippet
n/a
Additional information
Related: #1770 should allow tree shaking away these dependencies, although plenty of packages directly include node_modules (no build step) and the development install would still be large.
Node.js might expose
ProxyAgent
soon, allowing droppage of undici, once actions is bumped to 24 or whenever: nodejs/node#43187.Codecov PR: codecov/codecov-action#1524 (I used tinyglobby instead, but they ended up switching to bash)
The text was updated successfully, but these errors were encountered: