-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moviepy Roadmap - version 2.0 #1089
Comments
hi,do you hava a plan for this package to make it support GPU? |
@tburrows13 thanks for your reply,I also checked #790 and I will test ffmpeg which compiled with gpu library later,I will post the result when I finish testing. |
@tburrows13 hi,I modify the ffmpeg_reader.py as follows:
|
@misland, thanks for investigating. I'll have a look at some point to see if it would be benificial, but it doesn't seem to require much extra code on our part, so it will probably end up being an option for end users to use if they want to. |
I don't think that having v2 as a separate branch is really working, so I'll release v1.0.2 today, and then merge master into v2, then v2 back into master, so that new contributions will automatically be based off the v2 code. |
Now done, so all v2 code is in the current master branch. |
Oh, didn't see these last comment. I've been opening the prs against v2 :-) |
Ok, I'll delete v2 now as it doesn't seem to have any purpose. |
I thought that it would be a good idea to post my current thoughts regarding the v2.0 release (for my own sake as much as anything else!). There are a few outstanding major PRs that are still awaiting merges and there are a few more things that don't yet have a PR that I am still planning to do. Current PRs:
Other:
Documentation:
I'm very happy to discuss any of these plans before actually implementing them! |
do you mean GPU don't help to make moviepy do rendering jobs faster at all? |
Love to see this project moving forward. I don't see GPU acceleration in the progress update above, is this still on your radar? Would be incredibly useful in a lot of use-cases. I don't mind volunteering some time to help solve the GPU issue. |
Hello, thanks for your interest! Here's where I'm up to: I'll have some time over the next 4-5 weeks to work on moviepy and hopefully I'll be able to push v2.0 at the end of that.
As well as those 'big' items, I am planning to rework the documentation. The examples and tutorials are very outdated and lots of parameters are poorly documented or not mentioned at all. In addition, I'd like to move the docs to readthedocs.io, because they automatically update the docs on every push and they add a dropdown which allows the user to switch between docs for different versions. This allows future documentation improvements to take effect in realtime. When all of the above is done, I'd like to release it as 2.0.0. At various stages throughout it I'll probably release more dev releases (we already have v2.0.0.dev1). Here's where anyone/everyone else comes in :) You mentioned GPU acceleration: there have been a lot of requests for either that or multi-threading, because moviepy is quite slow! They would be great features to have, however I expect that they'd be quite complicated but also quite backwards-compatible so I see them as something that I'd probably work on for 2.1. However, if anyone else would like to do them and they are ready in time for 2.0, I'd happily add them in. #698 has a proof of concept for multi-threading. If you do decide to work on GPU/multi-threading, let me know what you are working on and I may be able to help :) |
A looong, long time ago, I updated and fixed parts of the docs, but the changes were ultimately rejected because I combined code + doc fixes. I'll try to dig them up to see if it would make sense to reuse them (or parts of them). |
Ok, I checked, and it looks like the changes I suggested back then were in fact merged in. (They just aren't labelled as mine because they happened within a PR.) |
I guess GPU support is one of the key feature with popular demand. It is preferred this is added in the settings file itself |
I would ask again for the GPU supporting for write_videofile, I see lots of demanding for this. Thank you |
@cryzed that seems like a good idea, and I think that it would be feasible. However, I don't think that that would be a breaking change, so I wouldn't neccasarily think it should go in v2.0. I'll continue to consider it though! |
@tburrows13 thank you for the quick reply, and yes I might have been a bit overeager in commenting it on this issue! Sorry about that :). I'm glad to hear you are considering it. |
@cryzed I feel you should look for the potential speedup GPU can provide. GpU does not necessarily speed up rendering. In my case it is around 1.3x speed up and not much. |
@dheerajmpai the speed is fine, that's not the problem. The problem is memory utilization. If I want to open 500 small files at once, 500 ffmpeg instances have to run in the background during the lifetime of the objects. |
Interesting implementation of using ffmpeg and a video card gpu in this library https://github.com/dmlc/decord |
In my case I try add '-hwaccel', 'cuda', '-c:v', 'h264_cuvid' params for read and write VideoFileClip and don't get any performance improvements. As result for reading I have started FFmpeg with this params: I don't know why adding cuda acceleration doesn't improve performance. Thanks. |
@pingvinton Did you mean to comment on this issue? It's specifically about progressing Moviepy as a library and your comment seems unrelated. Please open a separate, new issue in which you describe your problem in detail. |
Hi, are there any plans to release 2.0.0.dev3 on pypi? 2.0.0.dev2 was released in October 2020 and there is changes on master branch since then. 😅 |
Accordingly to #1768 (comment) it should be soon :) but AFAIK the #1076 PR needs to be merged before and it waits for fixes from the original maintainer. @tburrows13 is there any plan for moving the project closer to 2.0 release? |
Hey @averypfeiffer |
Me too! |
Is there a discord or communication channel we can use to communicate potential solutions and their trade-offs to issues, particularly if there is someone who knows why a particular thing was written a certain way or if they know about it? |
There's a Gitter (see link in README) but it's not really active. There is no other chat-like solution currently. |
https://twitter.com/gdb/status/1638971232443076609 apparently ChatGPT likes to use moviepy...?! |
Folks, do we have any update on GPU acceleration? Is it released or planned to be released soon? |
I’d like to propose an upcoming v2.0 which would allow us the opportunity to make a few small breaking changes, and remove some of the previously deprecated features.
Here’s some of the things that I’d like to include:
[Start v2.0 branch. Remove support for Python 2.7 & 3.4. #1103, Remove support for Python 3.5 #1106] Remove support for old Python versions (Drop support for python < 3.6 #1081)
I’d like to go through the backlog of complaints about resource usage and proper closing of clips and create a consistent cross-platform solution that can work for everyone, using some to-be-decided combination of
.close()
,.__del__()
and context managers (with ...:
). This would most likely not be backwards-compatible (Fixed problems with proc package #1016, Don't close the audio reader which might be linked from a shallow copy. #1059).We could enforce use of “keyword-only” arguments with the * (https://www.python.org/dev/peps/pep-3102/)
VideoFileClip("file.mp4", True, True, 100000)
would now be invalidIf it were possible to get rid of ImageMagick as a dependency, that would be amazing, its possible that everything that we use it for can now be done with imageio or one of our other, better behaved, dependancies. (Discussion in Imageio's new use of imageio-ffmpeg #908, TextClip produces low quality text #1472)
There are a lot of functions/methods with lots of optional parameters like https://github.com/Zulko/moviepy/blob/master/moviepy/video/fx/crop.py that require certain combinations of arguments to work. It would be nice to have a neat way of expressing this, maybe with decorators?
[Remove deprecated functions and parameters #1115] We can remove old deprecations
to_videofile
->write_videofile
to_audiofile
->write_audiofile
ColorClip(col=...)
[Renaming methods, parameters and variables for increased usability, consistency and readability #1170] We could go even further and improve the API even more
set_duration
->with_duration
etc is a common sticking point for new users not realising that it doesn't act inplace (TextClip positioning does not work #886) (or do what pandas does and have aninplace=False
parameter to everything, possibly handled by a decorator)set_start
(set_start and set_end have no effect other than changing the clip's duration #995)There are other things that need to be done, that, whilst they could be released at any time, would be good to include as part of a larger package
Since there's a lot of changes here, I'd propose merging them into a v2 branch first, before finally merging that into master when we're ready to release.Anything else that you can think of, agree/disagree with, let's discuss either here or on gitter!
The text was updated successfully, but these errors were encountered: