Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undesired log output #41

Open
tbruyelle opened this issue Dec 7, 2024 · 1 comment
Open

Undesired log output #41

tbruyelle opened this issue Dec 7, 2024 · 1 comment

Comments

@tbruyelle
Copy link

tbruyelle commented Dec 7, 2024 •
edited
Loading

Since v0.15.0 and more precisely since this commit 6981a36, ledger-go outputs a lot of log messages :

2024/12/07 10:47:04 Sending command: 5500000000
2024/12/07 10:47:04 Received response: 0002231A00330000049000
2024/12/07 10:47:04 Sending command: 5500000000
2024/12/07 10:47:04 Received response: 0002231A00330000049000
(...)

It is particularly visible when it is used inside a command line tool like a cosmos-sdk blockchain CLI.

If I'm not mistaken, these messages don't look useful and were probably added for debugging purposes. If you agree, I can create a PR to remove them. I would also be happy to have this fixed in a branch release of v1.0.0, because this is the version we are using and it's a bit far from master.
This was referenced Dec 7, 2024
Open
Closed
@tbruyelle
Copy link
Author

Hey guys, can I have a response to this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbruyelle