Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BunnymodXT fails to compile for windows #546

Closed
thomasdziedzic opened this issue Jul 31, 2024 · 5 comments · Fixed by #547
Closed

BunnymodXT fails to compile for windows #546

thomasdziedzic opened this issue Jul 31, 2024 · 5 comments · Fixed by #547
Labels

Comments

@thomasdziedzic
Copy link

I just cloned the repo (commit I'm using is 56bb64c) and tried to build it on windows. I got the following error:

BunnymodXT\BunnymodXT\helper_functions.hpp(27,4): error C3861: 'EngineMsg': identifier not found

I then looked through the commit/ci history on github and saw that ci has been failing for windows builds for the exact same reason:
https://github.com/YaLTeR/BunnymodXT/actions/runs/10122561202/job/27994847466#step:7:127

This error started happening with this commit:
0e20818

@YaLTeR
Copy link
Owner

YaLTeR commented Jul 31, 2024

Yeah, I merged a PR that's missing an include by accident. I'm waiting for @SmileyAG to fix it.

@thomasdziedzic
Copy link
Author

As a workaround, I checked out the commit right before the failing commit which is 2c06fda.

I can confirm that this fixes the build, though I think this issue should stay open until master is fixed.

@SmileyAG
Copy link
Collaborator

SmileyAG commented Jul 31, 2024

My apologies. There was just a queue of requests and more is awaiting, and in one of them I forgot to add #include for sptlib-wrapper.hpp by accident, and that's why the build broke. I wrote in the SourceRuns discord a couple of days ago that I would fix it as soon as I sit down to make new queue of requests again in a few days, but it seems that this moment has come now.

@SmileyAG
Copy link
Collaborator

@thomasdziedzic Also, if you want to contact us directly and maybe ask some questions about the reverse-engineering and etc, you can join the SourceRuns Discord and find the channel #goldsrc-tas, that's where we communicate
Discord invite URL: https://discord.gg/sourceruns

@thomasdziedzic
Copy link
Author

@SmileyAG thanks for fixing the issue!

Also thanks for the invite, I joined the discord channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants