Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Fahreza/playwright tests #107

Merged
merged 9 commits into from
Feb 23, 2022
Merged

🤖 Fahreza/playwright tests #107

merged 9 commits into from
Feb 23, 2022

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Feb 22, 2022

Description

This pull request focuses on automating the tests using Playwright. I have added the tests in ui-tests. The first test in this pull request is an E2E test that:

  1. Double click the examples folder in jupyter file browser
  2. Double click KerasPredict.xircuits
  3. Presses Save, Compile and Run, responding correctly to the window prompts.
  4. Selects the default kernel
  5. Waits until the Finish Executing
  6. If found. then test is successful.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Documentation
  • Others (Xircuits Validation)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Local Test

I have provided a readme in the ui-tests folder, but to test locally you can try:

  1. Open jupyterlab without access token.
    Note that it simulates a fresh fresh pull, so ensure that you don't have any active extensions and xircuits files open and you have the file browser on. Also, open it from base xircuits dir.
jupyter lab --NotebookApp.token=''
  1. Setup and run Playwright
cd ui-tests
npx playwright install
npm install -D @playwright/test
npx playwright test

Github Action Test

Please also verify whether the E2E action is successfully executed in Github actions.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> Github Actions)

Notes

Add if any.

@MFA-X-AI MFA-X-AI marked this pull request as ready for review February 22, 2022 08:56
@MFA-X-AI MFA-X-AI requested a review from AdrySky February 23, 2022 02:52
Copy link
Contributor

@AdrySky AdrySky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good works. Finally, xircuits have its own automation test. No more developers do all the testing, I hope so in the future.

Tested and LGTM. Just one small suggestion, can we have a short messages what's been done during the test process? This'll really help us understand where the error occurred. This can be done on the next PR. Nonetheless, Thank you.

@AdrySky AdrySky merged commit 09d8d60 into master Feb 23, 2022
@AdrySky AdrySky deleted the fahreza/playwright-tests branch February 23, 2022 03:07
@MFA-X-AI MFA-X-AI changed the title Fahreza/playwright tests 🤖 Fahreza/playwright tests Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants