Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint] always_declare_return_types #3

Open
evanweible-wf opened this issue Nov 8, 2019 · 1 comment
Open

[lint] always_declare_return_types #3

evanweible-wf opened this issue Nov 8, 2019 · 1 comment

Comments

@evanweible-wf
Copy link
Contributor

evanweible-wf commented Nov 8, 2019

http://dart-lang.github.io/linter/lints/always_declare_return_types.html

  • Overrides have to re-declare the return type, which is particularly annoying for libraries or patterns where this is common like over_react's render() method.
@regenvanwalbeek-wf
Copy link

We have upgraded this to error in DPC. I think workiva_analysis_options should consider upgrading this to warning or error in the future.

I haven't seen a much inconvenience in having to re-declare overridden return types. The benefits of preventing methods without declared return types outweigh the costs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants