Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit link to event details page #367

Open
wants to merge 14 commits into
base: trunk
Choose a base branch
from
Open

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented Oct 7, 2024

Fixes #365 and also displayed the notices on event details page using the wporg-notice block.

Before adding edit link

Screenshot 2024-10-09 at 09 59 45

After adding edit link
Screenshot 2024-10-09 at 09 59 28

Before using the notice block
Screenshot 2024-10-08 at 16 15 35

Screenshot 2024-10-08 at 16 02 21

After (using the notice block)
Screenshot 2024-10-08 at 16 21 48

Screenshot 2024-10-08 at 16 14 32

@trymebytes trymebytes changed the title Move notices out of attend button block Add edit link to event details page Oct 8, 2024
@trymebytes trymebytes marked this pull request as ready for review October 9, 2024 09:12
@trymebytes trymebytes requested a review from akirk October 9, 2024 09:12
@amieiro amieiro self-requested a review November 5, 2024 10:01
Copy link
Collaborator

@amieiro amieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Edit event" button, I suggest you to maintain the same look and feel that we are using in the new buttons:

  • Remove the icon.
  • Add the square border.

Before

image

With the suggestion

image

@trymebytes
Copy link
Collaborator Author

Here is how it looks now;
image

@trymebytes trymebytes requested a review from amieiro November 11, 2024 08:53
@akirk
Copy link
Member

akirk commented Nov 19, 2024

I can see a lot of space here if there is no edit event button: Screenshot 2024-11-19 at 10 50 43

If we align the Edit Event button with the headline and not on a separate line this would eliminate the problem.

@trymebytes
Copy link
Collaborator Author

Here's how it looks now, see below;

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Navigation Items to an event you can edit
3 participants