Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest media assets #57

Open
ashfame opened this issue Sep 25, 2024 · 2 comments
Open

Ingest media assets #57

ashfame opened this issue Sep 25, 2024 · 2 comments
Milestone

Comments

@ashfame
Copy link
Member

ashfame commented Sep 25, 2024

With the content liberated, we are still not handling the media assets, the images and whatnot, they would be hot linked to the origin URL. One of the ways we (@psrpinto and I) think would be to rely on a third party plugin to fix this for us afterwards as if you would do in a regular migration from a WordPress host to another host. That way we don't have to write a lot of code to do the things for which WP plugins exist out there and we can call them programmatically.

@psrpinto psrpinto added this to the MVP milestone Dec 5, 2024
@psrpinto psrpinto changed the title Handling media assets Ingest media assets Dec 5, 2024
@psrpinto
Copy link
Member

psrpinto commented Dec 5, 2024

I think we need to drill-down on this issue. For example:

  • At what point does the ingestion happen? Does it happen when the subject is created, or when it is transformed? Or between being created and transformed?
  • Which existing code we can leverage? Maybe something from data-liberation, or if it's a third-party plugin, we need to choose one.

@ashfame ashfame mentioned this issue Dec 6, 2024
@ashfame
Copy link
Member Author

ashfame commented Dec 9, 2024

Ideally speaking, storing raw data and running transformations, should be separate and the act of "transformation" should do everything that's required for the data to exist in WordPress.

But practically, this is what we have:

  • We have our raw data and partially transformed data (whatever transformations run on frontside via paste_handler of Gutenberg) saved together in a single subject, which is then used to create the final transformation output. No clean separation here.
  • Some of the transformation work (such as media assets import) would be handled in a post-transformation setup at the very end of the entire liberation process. This is where the libraries residing in Playground repo would come in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants