Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterations on W icon in the editor header #20929

Closed
2 tasks done
mtias opened this issue Mar 16, 2020 · 12 comments
Closed
2 tasks done

Iterations on W icon in the editor header #20929

mtias opened this issue Mar 16, 2020 · 12 comments
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Mar 16, 2020

#20579 introduced a WordPress icon button to function as the "view posts / go back" action in full-screen mode.

image

@mtias mtias added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Mar 16, 2020
@nickhamze
Copy link

This my favorite GitHub issue of all time. Thank you so much. The double ring logo makes me so sad. I can't wait to create all sorts of silly illustrations to replace that button with.

@karmatosed karmatosed added the Needs Dev Ready for, and needs developer efforts label Mar 16, 2020
@tijosh
Copy link

tijosh commented Mar 28, 2020

+1 to this. It would be good to have the option to change it to anything, or at least have the possibility to change it back to a left/back arrow.

@folletto
Copy link
Contributor

folletto commented Apr 23, 2020

I agree on this one. I opened #21795 with a similar suggestion. More specifically, I think we should allow to:

  1. Lock Gutenberg to be full-screen only
  2. Change the page where the (W) goes back to
  3. Bonus: even better if the look can be customized too as noted above.

Also in regard to #21121, it's important that in case of modification of the "back" behaviour, the sidebar behaviour can be overridden.

The reason is that this would address some use cases that would allow Gutenberg to be way more integrated in various flows.

Use cases:

  • Businesses could build custom workflows that open Gutenberg as their edit interface.
  • Agencies could have their own interfaces to simplify the interaction with their clients.
  • Products could use Gutenberg and make sure the user always come back to their UI.

In short, it should allow flows like:

Custom UI → Gutenberg → back to Custom UI

Bypassing WP Admin entirely, in order to avoid the user getting lost. Which would allow for example to build advanced "Themes" with specific functionality, relying on Gutenberg for editing, and back. Imagine specific, narrow, app-like services.

In short, it would make Gutenberg to be already more easily integrated.

@vindl
Copy link
Member

vindl commented May 13, 2020

Finished the first part of this issue with #22323.

@vindl vindl removed their assignment May 14, 2020
@folletto
Copy link
Contributor

folletto commented Jun 3, 2020

Heya @vindl does that mean it's possible now to add a hook to override the destination of the W like I mentioned above, or not yet?

I'm asking as I saw some work going on #22191 and I was wondering if it was already fixed, or if I should raise it again there.

@vindl
Copy link
Member

vindl commented Jun 3, 2020

Heya @vindl does that mean it's possible now to add a hook to override the destination of the W like I mentioned above, or not yet?

Hi @folletto - This allows replacing the whole default component and the custom component can provide a different destination.

If we are looking into modifying just the destination while preserving everything else, that might require the rest of the functionality to be essentially copied over. I think that this can be improved in a similar fashion as I did for icon replacement case.

@folletto
Copy link
Contributor

folletto commented Jun 3, 2020

Ok so it's doable even if it requires right now to rewrite the component.

And yes, would be a nice improvement if there was a way to just switch the "back" action, without changing everything else :)

@vindl
Copy link
Member

vindl commented Jun 4, 2020

And yes, would be a nice improvement if there was a way to just switch the "back" action, without changing everything else :)

I can look into that after #22191 gets merged in order to avoid introducing even more merge conflicts for them. :)

@folletto
Copy link
Contributor

folletto commented Jun 5, 2020

Thanks! :D

@vindl
Copy link
Member

vindl commented Jul 13, 2020

The second item has been resolved with merging of #22952.

@vindl vindl closed this as completed Jul 13, 2020
@vindl
Copy link
Member

vindl commented Nov 24, 2020

And yes, would be a nice improvement if there was a way to just switch the "back" action, without changing everything else :)

@folletto It took a while to circle back to this and we made some changes to how back button is handled in the site editor in the meantime (it's inside of nav menu, so a bit different than post editor). But this is now possible for both cases as of #27213.

@folletto
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants