Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing paragraph/interblock separators in right-open slice intervals #408

Closed
2 tasks done
Witiko opened this issue Feb 13, 2024 · 0 comments · Fixed by #419
Closed
2 tasks done

Remove trailing paragraph/interblock separators in right-open slice intervals #408

Witiko opened this issue Feb 13, 2024 · 0 comments · Fixed by #419
Assignees
Labels
bug lua Related to the Lua interface and implementation syntax extension Related to syntax extensions and dialects of markdown
Milestone

Comments

@Witiko
Copy link
Owner

Witiko commented Feb 13, 2024

As discovered by @lostenderman during their work on #403, using right-open slice intervals, such as sliced-div ^first-heading in test file lunamark-markdown/slice-fenced-divs.test, causes trailing paragraph/interblock separators to be produced at the end of the document. This may lead to rendering artefacts, since no separators would naturally be produced at the end of a document without the use of slicing.

Acceptance criteria

A pull request that closes this ticket should do the following:

  • Remove trailing paragraph/interblock separators in test files lunamark-markdown/*slice*.test.
  • Update the parser, so that continuous integration passes.
@Witiko Witiko added bug lua Related to the Lua interface and implementation syntax extension Related to syntax extensions and dialects of markdown labels Feb 13, 2024
@Witiko Witiko added this to the 3.4.1 milestone Feb 13, 2024
@Witiko Witiko modified the milestones: 3.4.1, 3.4.2 Feb 16, 2024
@Witiko Witiko assigned Witiko and unassigned lostenderman Feb 29, 2024
@Witiko Witiko modified the milestones: 3.4.2, 3.5.0 Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug lua Related to the Lua interface and implementation syntax extension Related to syntax extensions and dialects of markdown
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants