-
Notifications
You must be signed in to change notification settings - Fork 45
This package breaks bulma SASS builds #69
Comments
In my case (yarn2+pnp) it even stops the build:
|
Having same issue, Could you please fix and update npm package ? I'd be glad to provide a PR if needed. |
Just hit up against this one too. Is it an easy enough fix @CarlVerret? |
Following the guide (using SASS) here: Bulma Extensions Wiki
It worked for me |
Thanks @kdaveid, that just imports the precompiled version. If you want it to adjust to your custom |
Oh, I see, of course. My bad. |
I've come to the conclusion that there should be no imports of bulma dependencies in any of these bulma plugin sass files (if they're expected to be imported by the end-developer) as the developer should be expected to have already imported bulma before importing these sass source files so all the dependencies will already be in place. The build process for each of these packages should have an extra wrapper file that includes what is needed from bulma in order to build a standalone css file and the dependencies should be documented for those wanting to recompile the sass themselves. @Wikiki, are you open to PR's to address this? |
Also seeing an error adding this to my sass file and compiling
Not sure if this is the same issue, but not great :( |
Still broken, this drove me nuts. Currently I'm sticking with the full bulma-extensions package which is wasteful and has a deprecation warning relating to slash div, but it works. |
The following line breaks various bulma styles when
bulma
andbulma-checkradio
are built using SASSbulma-checkradio/src/sass/index.sass
Line 2 in c1323f8
This import changes the CSS order, causing the build output CSS to prefer certain styles over others, because the selectors have the same CSS specificity.
I.e. this line causes Bulma buttons to not have borders and button text to be aligned left, instead of centered.
The text was updated successfully, but these errors were encountered: