Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoding when charset is in the content type response header #904

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

manchuck
Copy link
Contributor

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck
Copy link
Contributor Author

Address #903

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (05cbf33) 83.38% compared to head (3df49e4) 83.41%.

Files Patch % Lines
packages/server-client/lib/client.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              3.x     #904      +/-   ##
==========================================
+ Coverage   83.38%   83.41%   +0.03%     
==========================================
  Files         121      121              
  Lines        1637     1646       +9     
  Branches      323      324       +1     
==========================================
+ Hits         1365     1373       +8     
- Misses        272      273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manchuck manchuck changed the title fix: decoding when charset is set in the content type response header fix: decoding when charset is in the content type response header Jan 19, 2024
@manchuck manchuck merged commit aec47d6 into 3.x Jan 22, 2024
13 checks passed
@manchuck manchuck deleted the fix-numbers-decoding branch January 22, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants