Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kubernetes provider overlays #370

Open
1 of 4 tasks
pawelprazak opened this issue Feb 6, 2024 · 8 comments
Open
1 of 4 tasks

Add Kubernetes provider overlays #370

pawelprazak opened this issue Feb 6, 2024 · 8 comments
Assignees
@pawelprazak
Labels
area/providers Everything related to providers good first issue Good for newcomers to the community impact/usability Something that impacts users' ability to use the product easily and intuitively kind/missing We are missing a part of functionality compared to upstream size/L Estimated effort to complete (up to 10 days).
Milestone
Post 1.0

Comments

@pawelprazak
Copy link
Contributor

pawelprazak commented Feb 6, 2024 •
edited
Loading

We are missing hand-crafted 'overlays' in Kubernetes provider:

  • CustomResource, CustomResourcePatch - frequently used k8s API (top priority) ~ 2 days
  • ConfigFile, ConfigGroup, Invokes, TransformationAction - yaml tools (2nd priority) ~ 3 days
  • helm abstractions (nice to have) ~ 3 days
  • kustomize abstractions (nice to have) ~ 2 days

Upstream:
https://github.com/pulumi/pulumi-kubernetes/blob/master/provider/pkg/gen/overlays.go
https://github.com/pulumi/pulumi-kubernetes/tree/master/provider/pkg/gen/nodejs-templates
@pawelprazak pawelprazak added good first issue Good for newcomers to the community kind/missing We are missing a part of functionality compared to upstream impact/usability Something that impacts users' ability to use the product easily and intuitively area/providers Everything related to providers size/L Estimated effort to complete (up to 10 days). labels Feb 6, 2024
@pawelprazak
Copy link
Contributor Author

pawelprazak commented Feb 10, 2024 •
edited
Loading

IIUC once pulumi/#1871 is done we won't have to add a hand-written overlay (at least some)

@pawelprazak pawelprazak added size/M Estimated effort to complete (up to 5 days). size/L Estimated effort to complete (up to 10 days). and removed size/L Estimated effort to complete (up to 10 days). size/M Estimated effort to complete (up to 5 days). labels Feb 15, 2024
@pawelprazak
Copy link
Contributor Author

the simplest solution would be to add codegen/resources/overlays and re-use ProviderConfig and reuse the existing codegen

@pawelprazak pawelprazak self-assigned this Feb 19, 2024
@pawelprazak pawelprazak added this to the 0.3.0 milestone Feb 19, 2024
@pawelprazak pawelprazak mentioned this issue Feb 22, 2024
Merged
@pawelprazak pawelprazak modified the milestones: 0.3.0, 1.0.0 Feb 22, 2024
@pawelprazak
Copy link
Contributor Author

Those new changes look relevant:
https://github.com/pulumi/pulumi/pull/15490/files#diff-5eea65419cabefe8dae546369e07a0cdc8d2ed74b58326724b49fba56637f910

@pawelprazak
Copy link
Contributor Author

As it turns out, upstream Pulumi is adding the resources that were implemented as overlays, as components:
pulumi/pulumi-kubernetes#1971

@pawelprazak
Copy link
Contributor Author

The helm and yaml support can be considered done via 4.11.0+ provider support.

@lbialy
Copy link
Collaborator

lbialy commented Apr 21, 2024

can we close this now, given this was fixed in upstream and inherited via code generation on our side?

@pawelprazak
Copy link
Contributor Author

pawelprazak commented Apr 23, 2024 •
edited
Loading

We're still waiting for full support (as indicated by checkboxes in this issue):

More info in the upstream epic: pulumi/pulumi-kubernetes#1971

What we have now is full yaml/v2.

@pawelprazak pawelprazak modified the milestones: 1.0.0, Post 1.0 Apr 25, 2024
@mjeffryes
Copy link

glad the work to create component versions of these overlays is proving useful to you all. FWIW, we are considering not going ahead with an MLC for CustomResource. Since the only function of this overlay is to pack arbitrary fields from the SDK into a single field for Pulumi, there's not really an equivalent component we could write. Plus the implementations in each SDK are relatively simple, making this overlay reasonable to write and support.

@polkx polkx mentioned this issue Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelprazak pawelprazak

Labels
area/providers Everything related to providers good first issue Good for newcomers to the community impact/usability Something that impacts users' ability to use the product easily and intuitively kind/missing We are missing a part of functionality compared to upstream size/L Estimated effort to complete (up to 10 days).
Projects
None yet
Milestone
Post 1.0
Development

No branches or pull requests
3 participants
@pawelprazak @mjeffryes @lbialy