Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POISE should halt if rotational frequency is close to pericenter angular frequency #142

Open
RoryBarnes opened this issue Apr 23, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@RoryBarnes
Copy link
Collaborator

A halt needs to be added to ensure POISE is not used at high eccentricity.

@RoryBarnes RoryBarnes added bug Something isn't working good first issue Good for newcomers labels Apr 23, 2021
@vmk8826
Copy link

vmk8826 commented May 1, 2021

can you please elaborate

@RoryBarnes
Copy link
Collaborator Author

Yes, of course! When a planet's instantaneous frequency becomes close to the rotational frequency, i.e. periastron of a high eccentricity orbit, then the assumptions underpinning POISE fail and the code should halt. This feature would be valuable when testing extreme climate variations with POISE coupled to an orbital model and the user was not sure how large the eccentricity could reach (see examples/ChaoticResonances). Whlie there is a dHaltMaxEcc option, the default value is 1.0, but for POISE the default should be something like 0.9. To make this change, one would need to modify halt.c:fniHaltMaxEcc to check if POISE was selected and if true, update dHaltMaxEcc to 0.9.

@RoryBarnes
Copy link
Collaborator Author

Actually, it'd probably be better to modify VerifyHalts in halt.c such that if POISE is selected, then dHaltMaxEcc is set to 0.9. Then there will be no need to perform an extra check in fniHaltMaxEcc, which would increase performance since that function is called every timestep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants