Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all the colors work well depending on darkmode or light mode on the computer #32

Open
VagishVela opened this issue Jul 12, 2021 · 3 comments
Open

Make sure all the colors work well depending on darkmode or light mode on the computer #32

VagishVela opened this issue Jul 12, 2021 · 3 comments
Milestone
UI/UX

Comments

@VagishVela
Copy link
Owner

No description provided.

@mustafaquraish
Copy link
Contributor

Just a note that the colours displayed on the terminal are controlled by the terminal itself, so this might be a bit tricker. For instance if the OS is in dark mode then it might be making the terminal invert / change some colours on it's own.

@briancohan
Copy link
Contributor

I feel like we should be able to define a style class or style theme

@VagishVela
Copy link
Owner Author

I like the idea of a style class or theme. Then we could have a "light" and "dark" mode?

@briancohan briancohan added this to the UI/UX milestone Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
UI/UX
Development

No branches or pull requests
3 participants
@briancohan @VagishVela @mustafaquraish