Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPU templates used in other users' private pipelines can be deleted by the template owner #550

Open
eea03 opened this issue Nov 10, 2015 · 2 comments

Comments

@eea03
Copy link

eea03 commented Nov 10, 2015

When user creates a DPU template as public, other users can use it in their pipelines.
When the DPU template owner decides to delete the template, there is a check that checks if the DPU is used in any pipeline. However, permission check filters out the private pipelines and check says that no pipeline uses the DPU and the DPU template is deleted.
Private pipelines of other users are broken - DPU is deleted

To check the existing pipelines is used PipelineFacade.getPipelinesUsingDPU() which is also used to get pipelines in DPU instances view

So what is the expected solution? Should the DPU template owner see all the pipelines using this template, even if they are private? This way he would see them in DPU instances list

Or we introduce just new check method that ignores permissions and checks also all private pipelines - maybe can give information about blocking pipelines (pipeline name, user, mail)

@tomas-knap
Copy link

The user (owner of the DPU template) should not for sure see the details of the private pipelines using it. So I suggest two ways, in the case user (DPU template owner) wants to delete his DPU template used in private pipelines of others:

  1. List of pipeline using the DPU template will contain all the pipelines, including private ones. Nevertheless, user cannot click and open the detail of the private pipelines, cannot run the pipeline etc.
  2. List of pipeline using the DPU template will contain only public pipelines (as now). Nevertheless, if this list is empty and user tries to delete the DPU template, a message can oocur, saying "the DPU template is used also in private pipelines of user X with email Y", so it cannot be deleted. Please contact such users, before the DPU can be removed." and the user cannot delete the DPU.

@skrchnavy
Copy link

There is 3rd way combining both above, to list user's pipelines and then one row with info about number of private pipelines using the DPU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants