Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.sample.properties is not well documented #366

Closed
jakubklimek opened this issue Apr 22, 2015 · 6 comments
Closed

config.sample.properties is not well documented #366

jakubklimek opened this issue Apr 22, 2015 · 6 comments

Comments

@jakubklimek
Copy link

https://github.com/UnifiedViews/Core/blob/develop/frontend/src/main/webapp/WEB-INF/config.sample.properties

I don't understand the comments for

  • ownership.type=user

I don't understend why this is in frontend's config

  • master.api.user=master
  • master.api.password=commander
@tomas-knap
Copy link

Please supplement explanation, as you did: #312

Currently, master API is done in a way that it stands next to frontend/backend, it is also package as independent war. So Jakub is right that the best would be if API module has its own config.properties, specified in a similar way as in case of frontend. Obviously master.war can point to the same config.properties as frontend/backend, but it is not necessary, if the user does not want.

@skrchnavy
Copy link

@eea02 / @eea03 to provide feedback

@eea03
Copy link

eea03 commented May 5, 2015

ownership.type config property will be removed shortly (already removed in feature branch) so I don't think it is necessary to bother with this

As for master configuration, @eea02 should provide feedback

@eea02
Copy link

eea02 commented May 5, 2015

Currently Master API shares configuration with frontend. I agree that it would be best if each application uses it's own configuration. I think, that there is already a feature request for this.

@skrchnavy
Copy link

There is a possibility that in #431 solution would be to merge master and frontend into one jar to safe memory, so this issue could be obsolete then. Lowering priority

@tomas-knap
Copy link

the only remaining problem - master section

@tomas-knap tomas-knap modified the milestones: Release v2.3.0, Release v2.4.0 Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants