Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcdf-c-4.5.0-rc2 build on cygwin broken #485

Closed
matzeri opened this issue Sep 16, 2017 · 2 comments
Closed

netcdf-c-4.5.0-rc2 build on cygwin broken #485

matzeri opened this issue Sep 16, 2017 · 2 comments

Comments

@matzeri
Copy link

matzeri commented Sep 16, 2017

I noticed that on current release candidate the NOUNDEFINED that is set in configure
for cygwin and other platform was removed from the Makefile.am.
This break the build on cygwin, and it was there on 4.4.1.1-1.
Reinstating it, the build is fine and pass all tests.

--- origsrc/netcdf-c-4.5.0-rc2/liblib/Makefile.am       2017-08-07 19:25:26.000000000 +0200
+++ src/netcdf-c-4.5.0-rc2/liblib/Makefile.am   2017-09-16 22:44:50.747636500 +0200
@@ -18,7 +18,7 @@ lib_LTLIBRARIES = libnetcdf.la
 # for information regarding incrementing `-version-info`.
 ##

-libnetcdf_la_LDFLAGS = -version-info 12:0:1
+libnetcdf_la_LDFLAGS = -version-info 12:0:1 ${NOUNDEFINED}

 libnetcdf_la_CPPFLAGS = ${AM_CPPFLAGS}
 libnetcdf_la_LIBADD =

@edwardhartnett
Copy link
Contributor

This is very old. Is this issue still relevant or should it be closed?

@matzeri
Copy link
Author

matzeri commented Apr 29, 2022

forgot about it. Same of #2196 that has been solved

@WardF WardF closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants