Unexpected simulation error for Tank with volume curve and CanOverflow

[pajarrige]

When a model contains one or more tank with a volume curve AND CanOverflow attribute, it cannot be simulated from GUI:

• simulation is OK with the toolkit.
• opening the model with Epanet is OK.
• when running the analysis you get "Error 206: undefined curve -16s in [TANKS] section:" error.
  See the .inp file attached
  Tank_vol_curve+overflow.inp.txt

[lbutler]

This bug is caused by Line 402 the following section of code:

EPANET2.2/Delphi_GUI/epanet2w/Uexport.pas

Lines 398 to 407 in 0086aec

	if SameText(Data[TANK_OVERFLOW_INDEX], 'Yes') then
	begin
	if Length(Trim(Data[TANK_VCURVE_INDEX])) = 0
	then s := s + '* '#9
	else s := s + Format('-16s'#9, [Data[TANK_VCURVE_INDEX]]);
	s := s + 'Yes'#9';' + Data[COMMENT_INDEX];
	end
	else s := s + Format('%-16s'#9';%s', [Data[TANK_VCURVE_INDEX],
	Data[COMMENT_INDEX]]);
	Writeln(F, s);

The Format function is missing the % character and the line should be rewritten like so:

else s := s + Format('%-16s'#9, [Data[TANK_VCURVE_INDEX]]);

I tested this over at the OWA EPANET GUI and was able to fix the bug.