Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider failing early for reading >100 MiB files #22

Open
craigwalton-dsit opened this issue Dec 19, 2024 · 0 comments
Open

Consider failing early for reading >100 MiB files #22

craigwalton-dsit opened this issue Dec 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@craigwalton-dsit
Copy link
Collaborator

SandboxEnvironment.read_file() on files over 100 MiB should raise an OutputLimitExceededError error.

At present, we'll raise this error upon reading 100 MiB + 1 byte, but we could fail early by adding some check that the file is <= 100 MiB before starting the read (acknowledging that there is a race condition). This would add a bit of complexity, but maybe we'd wrap it up in a small /bin/sh script.

@craigwalton-dsit craigwalton-dsit added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant