Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad practice: TerminationGracePeriodSeconds: 0 #19

Open
craigwalton-dsit opened this issue Dec 19, 2024 · 0 comments
Open

Bad practice: TerminationGracePeriodSeconds: 0 #19

craigwalton-dsit opened this issue Dec 19, 2024 · 0 comments

Comments

@craigwalton-dsit
Copy link
Collaborator

The docs are pretty vocal about not doing this
https://kubernetes.io/docs/tasks/run-application/force-delete-stateful-set-pod/#statefulset-considerations

inspect_k8s_sandbox/src/k8s_sandbox/resources/helm/agent-env/templates/services.yaml

Line 34 in f585459

terminationGracePeriodSeconds: 0

The practice of setting a pod.Spec.TerminationGracePeriodSeconds of 0 seconds is unsafe and strongly discouraged for StatefulSet Pods

We do this because most containers we run don't respect signals properly. Ideally we'd have an init feature like Docker does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craigwalton-dsit