Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added logic on pathProps to re-instance nodes once args change #367

Merged
merged 3 commits into from
Aug 17, 2023
Merged

fix: added logic on pathProps to re-instance nodes once args change #367

merged 3 commits into from
Aug 17, 2023

Conversation

alvarosabu
Copy link
Member

Closes #366

@alvarosabu alvarosabu added the bug Something isn't working label Aug 17, 2023
@alvarosabu alvarosabu requested a review from enpitsuLin August 17, 2023 13:41
@alvarosabu alvarosabu self-assigned this Aug 17, 2023
@netlify
Copy link

netlify bot commented Aug 17, 2023 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 1866be1
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/64de259bb7232300071730c5
😎 Deploy Preview https://deploy-preview-367--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

enpitsuLin
enpitsuLin requested changes Aug 17, 2023
View reviewed changes
src/core/nodeOps.ts Show resolved Hide resolved
@alvarosabu alvarosabu merged commit 453b031 into main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enpitsuLin enpitsuLin enpitsuLin approved these changes

Assignees

@alvarosabu alvarosabu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-instance THREE instances via args prop reactivity
2 participants
@alvarosabu @enpitsuLin