Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose effectComposer #83

Merged
merged 4 commits into from
Nov 17, 2023
Merged

fix: expose effectComposer #83

merged 4 commits into from
Nov 17, 2023

Conversation

alvarosabu
Copy link
Member

@alvarosabu alvarosabu commented Nov 17, 2023 •
edited
Loading

I managed to solve the problem in docs by exposing the effectComposer via templateRef and disposing it on route change.

Seems like Vitepress doesn't trigger onUnmounted when the routes change.

Fixes #57 #67

@alvarosabu alvarosabu requested a review from Tinoooo November 17, 2023 09:21
@alvarosabu alvarosabu added the bug Something isn't working label Nov 17, 2023
@Tinoooo Tinoooo merged commit 4878a95 into main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tinoooo Tinoooo Tinoooo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs are broken in productive build
2 participants
@alvarosabu @Tinoooo