Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): remove Environment demo #538

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented Nov 25, 2024

Problem

useProgress does not appear to work if multiple demos are on a single page.

Solution

Remove second demo from docs page at http://localhost:5173/guide/staging/environment.html

Closes #391

- Github links to images were bringing up a 404.
- `useProgress` does not appear to work if multiple demos are on a
  single page.
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit c25daa4
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/67508cdd05b63300086f917e
😎 Deploy Preview https://deploy-preview-538--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 marked this pull request as ready for review November 25, 2024 09:51
Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/cientos@538

commit: bf115e2

@andretchen0 andretchen0 changed the title fix(docs): remove Environment demo, fix links fix(docs): remove Environment demo Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: guide/staging/environment demo doesn't load
2 participants