Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train EIIE - time_steps config value is ignored and not passed to environment #198

Open
joshwigginton opened this issue Feb 22, 2024 · 0 comments

Comments

@joshwigginton
Copy link

If you change the time_steps parameter in the EIIE portfolio management config, these values seem to be ignored and time_steps 10 is always used.

In the trademaster/environments/portfolio_management/eiie_environment.py file,
self.time_steps = get_attr(self.dataset, "time_steps", 10)

As far as I can tell, time_steps is not an attribute of self.dataset or kwargs passed to the environment, so the default of 10 is used.

To reproduce using the Tutorial EIIE notebook:

  1. Change the time_steps value in portfolio_management_dj30_eiie_eiie_adam_mse.py
  2. Load config, build data set, build environment, build net
  3. Check cfg.act.time_steps and it will be 10, not the value set in the portfolio_management config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant