Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not accept WHATWG URL #61

Closed
JonathanWilbur opened this issue Feb 19, 2019 · 2 comments
Closed

Does not accept WHATWG URL #61

JonathanWilbur opened this issue Feb 19, 2019 · 2 comments
Assignees

Comments

@JonathanWilbur
Copy link

This library does not accept WHATWG URLs. See this bug, which I have written up for one of this library's dependencies: TooTallNate/node-agent-base#26. An additional bug writeup that may be instructive is nodejs/node#26198.

You will also have this same issue with this line of code in this package:

  var proxy = Object.assign({}, opts);
@sadasant
Copy link
Collaborator

sadasant commented Jul 6, 2019

@JonathanWilbur what do you think of this approach? #71

@TooTallNate
Copy link
Owner

This module has gone through a large refactor and modernization. I am closing this issue as a bit of house cleaning. If you feel that this issue still exists in the latest release, feel free to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants