Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch JSON data directly instead of providing patched versions #6

Open
Thesola10 opened this issue Mar 23, 2022 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Thesola10
Copy link
Owner

This would make the repository a lot lighter, as well as reduce this repository's "attack surface" in terms of copyrighted data, and make sensitive data less likely to be mangled, like in #3.

A potential candidate for this would be RFC 6902, which already has a Python package.

@Thesola10 Thesola10 added enhancement New feature or request good first issue Good for newcomers labels Mar 23, 2022
@Thesola10
Copy link
Owner Author

Two other enhancements come to mind if this is implemented:

  • We could consolidate MonoBehaviour patches into a single file, by using a JSON set enumerated by object IDs
  • We could employ this method to patch scrpt.cpk contents as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant