-
Notifications
You must be signed in to change notification settings - Fork 35k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disclaimer about not submitting personal solutions to PULL_REQUEST_TEMPLATE.md for all exercise repos #380
Comments
Yeah I agree with this. We definitely need to make it more visible. |
What do you think about adding the line and also adding a bit of bolding in the bullet point?
|
Honestly we could probably move that verbiage to the opening paragraph:
Also wouldn't be opposed to adding a comment in the PR template. @Asartea did you still want to be assigned? |
yes |
@Asartea you got it. There is a similar issue linked above from our css exercise repo which should be taken into account. If you have any questions feel free to ping! |
@Asartea If you want to update the CSS one as well that is fine, or I will do it. Either way we should coordinate our language I think. |
I have gone ahead with the css repo: TheOdinProject/css-exercises#493 |
Sorry, I have been really busy and then really sick. Will give this a look now |
No worries! Hopefully you're feeling better, but take your time! |
@Asartea just an FYI I merged the PR in the css exercise repo. If we'd want to tweak any verbiage further in this js exercise readme we can do a followup for CSS. |
@Asartea Anything needs doing further with this? |
I have no memory of this place In all seriousness, I can't recall even opening this issue, so I'll need to read myself in to see what the state of it is; will see when I have time |
Complete the following REQUIRED checkboxes:
location for request: brief description of request
format, e.g.Exercises: Add exercise on XYZ
The following checkbox is OPTIONAL:
1. Description of the Feature Request:
There are still regularly people who submit personal solutions to all of the various exercise repos. We do mention that those repos don't accept solutions in the README.md, but that line is unhighlighted, at the bottom, and easily missable. Furthermore due to the fork > clone > solve > upload to personal repo workflow that a learner is likely to use when solving the exercises, they will get a big yellow/orangeish banner above both their own repo and the forked repo with a call out to Contribute now. Adding an additional line somewhere in the PR template (
<!-- WARNING: Do not submit personal solutions to this repo. Pull Requests containing personal solutions will be summarily closed and will not be merged -->
?) would provide another layer of catching a learners eyes before they submit a superflous PR2. Acceptance Criteria:
The text was updated successfully, but these errors were encountered: