Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disclaimer about not submitting personal solutions to PULL_REQUEST_TEMPLATE.md for all exercise repos #380

Open
3 of 4 tasks
Asartea opened this issue Jul 21, 2023 · 12 comments
Assignees
Labels
Status: Awaiting Response Waiting for a response from the contributor

Comments

@Asartea
Copy link
Contributor

Asartea commented Jul 21, 2023

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the location for request: brief description of request format, e.g. Exercises: Add exercise on XYZ

The following checkbox is OPTIONAL:

  • I would like to be assigned this issue to work on it

1. Description of the Feature Request:
There are still regularly people who submit personal solutions to all of the various exercise repos. We do mention that those repos don't accept solutions in the README.md, but that line is unhighlighted, at the bottom, and easily missable. Furthermore due to the fork > clone > solve > upload to personal repo workflow that a learner is likely to use when solving the exercises, they will get a big yellow/orangeish banner above both their own repo and the forked repo with a call out to Contribute now. Adding an additional line somewhere in the PR template (<!-- WARNING: Do not submit personal solutions to this repo. Pull Requests containing personal solutions will be summarily closed and will not be merged --> ?) would provide another layer of catching a learners eyes before they submit a superflous PR

2. Acceptance Criteria:

  • Some form of warning is added to all PR templates in the various exercise repos
@Asartea Asartea added the Status: Needs Review This issue/PR needs an initial or additional review label Jul 21, 2023
@CouchofTomato
Copy link
Member

Yeah I agree with this. We definitely need to make it more visible.

@Asartea
Copy link
Contributor Author

Asartea commented Jul 24, 2023

What do you think about adding the line and also adding a bit of bolding in the bullet point?

Do not submit your solutions to this repo, as any PRs that do so will be closed without merging.

@thatblindgeye
Copy link
Contributor

Honestly we could probably move that verbiage to the opening paragraph:

These JavaScript exercises are intended to complement the JavaScript content on The Odin Project (TOP). They should only be done when instructed during the course of the curriculum. Please DO NOT submit your solutions to this repo, as any PRs that do so will be closed without merging.

Also wouldn't be opposed to adding a comment in the PR template. @Asartea did you still want to be assigned?

@thatblindgeye thatblindgeye added Status: Awaiting Response Waiting for a response from the contributor and removed Status: Needs Review This issue/PR needs an initial or additional review labels Feb 4, 2024
@Asartea
Copy link
Contributor Author

Asartea commented Feb 5, 2024

@Asartea did you still want to be assigned?

yes

@thatblindgeye
Copy link
Contributor

@Asartea you got it. There is a similar issue linked above from our css exercise repo which should be taken into account. If you have any questions feel free to ping!

@Unique-Pixels
Copy link

@Asartea If you want to update the CSS one as well that is fine, or I will do it. Either way we should coordinate our language I think.

@Unique-Pixels
Copy link

I have gone ahead with the css repo: TheOdinProject/css-exercises#493

@Asartea
Copy link
Contributor Author

Asartea commented Feb 28, 2024

Sorry, I have been really busy and then really sick. Will give this a look now

@thatblindgeye
Copy link
Contributor

No worries! Hopefully you're feeling better, but take your time!

@thatblindgeye
Copy link
Contributor

@Asartea just an FYI I merged the PR in the css exercise repo. If we'd want to tweak any verbiage further in this js exercise readme we can do a followup for CSS.

@MaoShizhong
Copy link
Contributor

@Asartea Anything needs doing further with this?

@Asartea
Copy link
Contributor Author

Asartea commented Sep 1, 2024

I have no memory of this place

In all seriousness, I can't recall even opening this issue, so I'll need to read myself in to see what the state of it is; will see when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Response Waiting for a response from the contributor
Projects
None yet
Development

No branches or pull requests

5 participants