using stringByEvaluatingJavaScriptFromString

[revolunet]

Hey there,

Thanks for the great plugin !

when using it with https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin we have a small issue :

This code, which evaluates the position from the webView, returns null :
return [self.webView stringByEvaluatingJavaScriptFromString:@"window.plugins.socialsharing.iPadPopupCoordinates();"];

The result is correct when calling from Safari directly; Any idea whats going on ?

thanks !

[EddyVerbruggen]

Hi, I'm afraid the WKWebView equivalent of UIWebViews stringByEvaluatingJavaScriptFromString is asynchronous rendering this approach of the SocialSharing plugin incompatible.

I have updated SocialSharing just now to deal with the null/nil result and position the popup at the bottom of the page (which is what iPhone does and what iPad did on iOS 7).

[revolunet]

Ok thanks for detailed answer and the workaround!

[revolunet]

@EddyVerbruggen : what do you think about adding a coords parameter to the share method ?

[EddyVerbruggen]

I'm considering creating a new share function with a different name which simply takes a JSON object to specify anything you want. That way features like the iPad popup coordinates can easily be added without making a mess of the API. But don't hold your breath as it won't be any day soon.