Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove submodule directory #138

Merged

Conversation

j-mew-s
Copy link
Contributor

@j-mew-s j-mew-s commented Feb 24, 2023

This reference is hanging around after removing the submodules file and is causing us errors during build:
No url found for submodule path 'cmake/tl-cmake' in .gitmodules

You can also see this error in your Actions run in the Post Run Actions/checkout@v3 step following the commit removing the submodules file e.g. here https://github.com/TartanLlama/expected/actions/runs/4260972315/jobs/7414746037

/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
fatal: No url found for submodule path 'cmake/tl-cmake' in .gitmodules
Warning: The process '/usr/bin/git' failed with exit code 128

Since it was after the run steps, I guess the build counted as successful though.

Disclaimer: I'm new to git submodules, apologies if I've misunderstood something!

@TartanLlama TartanLlama merged commit 3e304a4 into TartanLlama:master Feb 24, 2023
@j-mew-s
Copy link
Contributor Author

j-mew-s commented Feb 24, 2023

Thanks for dealing with this quickly, much appreciated 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants