-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove undefined behaviour #117
Merged
TartanLlama
merged 3 commits into
TartanLlama:master
from
daira:remove-undefined-behaviour
Feb 15, 2023
Merged
Remove undefined behaviour #117
TartanLlama
merged 3 commits into
TartanLlama:master
from
daira:remove-undefined-behaviour
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
force-pushed
the
remove-undefined-behaviour
branch
from
September 5, 2022 15:40
786a6ae
to
57d89eb
Compare
Note that the assertion behaviour can be overridden by defining a |
This was referenced Sep 5, 2022
Could you merge it? |
This affects operator->, operator*, and error() on a tl::expected instance. The performance impact is likely negligible for typical uses. refs TartanLlama#113 Signed-off-by: Daira Hopwood <[email protected]>
Signed-off-by: Daira Hopwood <[email protected]>
daira
force-pushed
the
remove-undefined-behaviour
branch
from
December 8, 2022 20:59
57d89eb
to
19e3dba
Compare
I've rebased this to current master. |
Signed-off-by: Daira Hopwood <[email protected]>
daira
added a commit
to daira/tl-docs
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Daira Hopwood <[email protected]>
Hi @TartanLlama. Are you available to give this a review? |
12 tasks
TartanLlama
approved these changes
Feb 15, 2023
12 tasks
Note that TartanLlama/tl-docs#4 is a related doc change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assertions for cases where the API documents undefined behaviour. This affects
operator->
,operator*
, anderror()
on atl::expected
. The performance impact is likely negligible for typical uses. refs #113