Issues compiling with exceptions disabled #129
Comments
andy-byers
pushed a commit
to andy-byers/expected
that referenced
this issue
Jan 15, 2023
+ Added a `[maybe_unused]` attribute to get rid of an unused parameter warning + Moving the parameter into `assign_common()` in the rvalue reference overload of `assign()` + Added a compile guard to `swap.cpp` to allow compilation with `-fno-exceptions`
andy-byers
pushed a commit
to andy-byers/expected
that referenced
this issue
Jan 15, 2023
+ Fixed unused variable warning + Added a `std::move` to avoid calling copy-assignment operator on non-copyable types
TartanLlama
pushed a commit
that referenced
this issue
Feb 15, 2023
+ Fixed unused variable warning + Added a `std::move` to avoid calling copy-assignment operator on non-copyable types Co-authored-by: andy-byers <[email protected]>
|
Everything works as expected when compiling with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've noticed the following two things when compiling with
-fno-exceptions:expected.hpp(using b74fecd for reference, but it's the same withv1.0.0)Hopefully that makes sense. Thanks for the great library!
The text was updated successfully, but these errors were encountered: