Removal of all process.env references #2014
Unanswered
bartoszgolebiowski
asked this question in
General
Replies: 1 comment
-
this is the solution how to determinate if is dev or not var __DEV__ = "development" !== 'production'; |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello react-table developers,
You have fantastic lib I love it but without further do I want to ask.
"Is it necessary to use process.env in your lib?"
I have checked to react, react-dom react-router @material-ui/core lib and there are not even one invoke of process.env or even process.* in codebase.
It is fine for SPA application, where process.env.NODE_ENV is somehow evaluated.
console.log(process) before usage of useTable()
but if you are using 'react-table' as an external dependency in webpack config, and download it via CDN to you HTML file using SystemJS, this "process.*" cause exception.
"Is it necessary to use process.env in your lib?"
This is how I import react-table dep to my html file.
Beta Was this translation helpful? Give feedback.
All reactions