-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
875026: implemented the CompareFiles and CompareUrlFiles api. #44
Open
ghost
wants to merge
9
commits into
master
Choose a base branch
from
875026-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suriya-Murugan
requested changes
Mar 8, 2024
data.RevisedFile.CopyTo(stream1); | ||
stream1.Position = 0; | ||
string json = ""; | ||
WordDocument.MetafileImageParsed -= OnMetafileImageParsed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
if (data.OriginalFilePath == null || data.RevisedFilePath == null) | ||
return null; | ||
string json = ""; | ||
WordDocument.MetafileImageParsed -= OnMetafileImageParsed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature description
Implement the CompareFiles and CompareUrlFiles api.
Analysis and design
If there is an external design, link to its project documentation area.
If there is an internal discussion on the forum, provide the link.
Solution description
Added the APIs.
Output screenshots
Post the output screenshots if an UI is affected or added due to this feature.
Areas affected and ensured
List the areas are affected by your code changes.
Jasmine Test cases
Pagination & E2E Test case merge request
Testing checklist
Collaborative Editing checklist
Web service link: https://github.com/essential-studio/ej2-documenteditor-collaborative-editing-services/tree/850940-Collab
Blazor Testing checklist
Is the feature moved to Blazor platform?
If YES
Theme changes
Additional checklist