Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

875026: implemented the CompareFiles and CompareUrlFiles api. #44

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2024

Feature description

Implement the CompareFiles and CompareUrlFiles api.

Analysis and design

If there is an external design, link to its project documentation area.
If there is an internal discussion on the forum, provide the link.

Solution description

Added the APIs.

Output screenshots

Post the output screenshots if an UI is affected or added due to this feature.

Areas affected and ensured

List the areas are affected by your code changes.

Jasmine Test cases

Testcase Name Spec file name Test case purpose

Pagination & E2E Test case merge request

Repository Merge request link(targeted to development)
ej2-documenteditor-test/PaginationNUnitAutomation MR link

Testing checklist

Item Comments
Is the SFDT exporting working fine.
Is the Docx exporting working fine.
Is the exported SFDT opening properly in DocumentEditor?
Is the exported Docx opening properly in DocumentEditor?
Is there any data loss in the file after saving is DocumentEditor? If Yes, Please list the features.

Collaborative Editing checklist

Item Comments
Have you ensured the changes in Collaborative editing

Web service link: https://github.com/essential-studio/ej2-documenteditor-collaborative-editing-services/tree/850940-Collab

Blazor Testing checklist

Is the feature moved to Blazor platform?

  • YES.
  • NO. Created task to track it. Share task link.
  • NA

If YES

Item Comments
Is feature moved to the Blazor script also?
Is feature ensured in the Blazor?
ej2-blazor-source MR

Theme changes

Item Comments
Is fix require theme changes? Yes, PR link https://github.com/essential-studio/ej2-theme-studio

Additional checklist

Checklist Comments
Did you run the automation against your implementation?
Is there any API name change? If yes, Provide the API review task.
Is there any existing behavior change of other features due to this code change?
Did you record this case in the unit test or UI test?

data.RevisedFile.CopyTo(stream1);
stream1.Position = 0;
string json = "";
WordDocument.MetafileImageParsed -= OnMetafileImageParsed;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

if (data.OriginalFilePath == null || data.RevisedFilePath == null)
return null;
string json = "";
WordDocument.MetafileImageParsed -= OnMetafileImageParsed;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant