Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop: true completion should be pop: 1 in version: 2 syntaxes #354

Closed
keith-hall opened this issue Oct 2, 2021 · 2 comments
Closed

pop: true completion should be pop: 1 in version: 2 syntaxes #354

keith-hall opened this issue Oct 2, 2021 · 2 comments
Milestone

Comments

@keith-hall
Copy link
Member

PackageDev currently always offers a completion of pop: true, but when the sublime-syntax file specifies version: 2, pop: 1 is preferred, so it would be nice if PackageDev would check the version and offer the relevant default pop value based on that :)

@UltraInstinct05
Copy link
Contributor

I guess, even with version: 2, we should not impose pop: 1. Maybe after pop: | <- caret, we could present an additional AC of true & 1, with default to 1 ? We could get even advanced and have 1 selected with an ability to increment if you press up/down (since pop supports knocking off arbitrary no. of contexts off the stack now in ST4)

@FichteFoll
Copy link
Member

pop: ${1:1} is what I would go with.

@FichteFoll FichteFoll added this to the 3.3.2 milestone Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants