Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md Badge to v0.35.1 to avoid lint errors #7

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

sharifm-informatica
Copy link
Contributor

Update README.md Badge to v0.35.1 to avoid lint errors

Update README.md Badge to v0.35.1 to avoid lint errors
@sharifm-informatica
Copy link
Contributor Author

Is it necessary to bump the Chart version with the app version? Or is it better that the chart version only changes when chart-specific changes happen not just app version updates?

What do you think? I am running into this choice in my other charts.

@M0NsTeRRR
Copy link
Contributor

I will add a contributing guide, but you have to bump the version in the Chart.yaml and then run the helm-docs command that will regenerate the README.md.

We must bump chart version otherwise the new version would not be available in the helm repo, also we have to follow semver (bump minor appVersion => bump minor version)

@Frooodle Frooodle merged commit 5c57fea into Stirling-Tools:main Dec 5, 2024
1 check failed
@M0NsTeRRR
Copy link
Contributor

M0NsTeRRR commented Dec 5, 2024

As discussed with @Frooodle, I will address this PR issue in another PR. However, my comment still stands (merge misclick 😄).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants