-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites don't reliably show up in iframe #12
Comments
Should we not allow the site to be submitted if it doesn't pass the iFrame test? Otherwise we will still need to remove the content for UX purposes? I'm documenting websites that have an iframe issue on the 'site list' tab here, will have 'IFRAME ISSUE' in columns A and B: https://docs.google.com/spreadsheets/d/1eBMImYmmqA8_JxlsGw-2Gv5Pcvcx4XOPsv0nLHfpIog/edit#gid=1172839891 I'll be updating the list as I come across more until a tool or fix is implemented. |
Went through the list of websites that have been submitted! 30% (33 out of 108) of websites have iFrame issues.Types of rendering issues:
https://i.redd.it/9tysquw33d161.jpg
https://www.incredibox.com/demo/
Types of websites that result in iFrame rendering issues
https://www.mayoclinic.org/healthy-lifestyle/adult-health/in-depth/bone-health/art-20045060 |
8/8: Discussion of issue with team
Beyonder: integrate iFrame tester tool in the website and add as part of the 'add site' user flow. If it's not compatible, create a popup and notify user? |
Testing feedback with X-frame bypass https://jsfiddle.net/w3bod6s5/ https://www.nature.house/ https://www.houzz.com/hznb/projects/hillside-views-watertown-pj-vj~2702921 Error 403 Not Allowed Error 54113 Varnish cache server https://www.nature.com/articles/s41586-023-06291-2 https://www.buzzfeed.com/mackenziekruvant/things-you-should-never-say-on-a-first-date https://www.mayoclinic.org/healthy-lifestyle/adult-health/in-depth/bone-health/art-20045060 https://neueux.com/apps https://www.fon.hum.uva.nl/rob/Courses/InformationInSpeech/CDROM/Literature/LOTwinterschool2006/szabo.best.vwh.net/smart_contracts_2.html https://www.incredibox.com/demo/ https://agar.io/ 10: https://i.redd.it/9tysquw33d161.jpg 9gag.com |
inital iframe bypass using proxy https://jsfiddle.net/w3bod6s5/ |
@jp4g feedback - aligned on feedback, seems like this is the best workaround to move forward with @thebeyondr - to support more on this since high prio for UX @NicoSerranoP - idea to open new popup for each new channel, esp. if there is an iframe issue? However, this disrupts the in-app experience |
Summarizing the approach to tackling this major issue
|
on the submit URL interface, we should let user to quickly check if the URL can render properly.
the interface should contain a small message to let user know if the URL didn't load into the iFrame, means it's not working.
The text was updated successfully, but these errors were encountered: