Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Replace gulp with a modern build system for st2web #23

Closed
blag opened this issue May 19, 2020 · 4 comments
Closed

Proposal: Replace gulp with a modern build system for st2web #23

blag opened this issue May 19, 2020 · 4 comments
Labels
proposal TSC:voting Items related to Technical Steering Committee voting

Comments

@blag
Copy link

blag commented May 19, 2020

Motivation

The Gulp build system is no longer supported, but the st2web repository has not been updated to use something else. This increases the signal-to-noise ratio of dependency alerts we receive for that repository. Luckily, a lot of the outdated dependencies are only development dependencies that will never see production, but automated scanners will still report those to us, and might cause us to miss an outdated non-development dependency, since it "normalizes deviance".

Solution

We should replace the current build system, Gulp, with something that is maintained, like Webpack.

Downsides

We don't have a lot of front end developers, so this may be a lot of effort for the developers that we do have. However, switching to a more modern, updated build system might lower the barrier to contribute, thereby making it easier for more frontend developers to engage with the project and contribute additional fixes and features.

Alternatives

We can just live with the out-of-date development dependency notifications, as long as we guarantee that they aren't used in production. This seems fairly easy to guarantee, but not necessarily easy to live with.


I am not a frontend developer, so it would be helpful to have at least one or two frontend developers weigh in on this (paging @guzzijones and @bgaeddert).

@blag blag added proposal TSC:voting Items related to Technical Steering Committee voting labels May 19, 2020
@guzzijones
Copy link

Afaik gulp is still supported. What package specifically are we talking to?
Let me do some digging again today and get you some specifics here to help.

I dont have a ton of gulp experience. I usually just use create react app for my projects.

Webpack does a lot of things gulp does, Yes.

@guzzijones
Copy link

[ubuntu@ip-128-126-44-42]~/projects/st2web$ npm ls gulp-util
[email protected] /home/ubuntu/projects/st2web
└─┬ @stackstorm/[email protected] -> /home/ubuntu/projects/st2web/tasks
  ├── [email protected]
  └─┬ [email protected]
    └── [email protected]

Not used in the codebase.
StackStorm/st2web#756

@guzzijones
Copy link

spoke on the phone about his with @punkrokk . gulp is not deprecated. We are sticking with gulp. The above PR removes an unused dependency on deprecated gulp-util

@blag
Copy link
Author

blag commented May 28, 2020

Thanks for the feedback @guzzijones! Closing.

@blag blag closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal TSC:voting Items related to Technical Steering Committee voting
Projects
None yet
Development

No branches or pull requests

2 participants