Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Breadcrumbs overwrites property types every time it is loaded #580

Open
Signynt opened this issue Nov 11, 2024 · 1 comment
Open

Bug: Breadcrumbs overwrites property types every time it is loaded #580

Signynt opened this issue Nov 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Signynt
Copy link

Signynt commented Nov 11, 2024

Describe the bug

When using properties as an edge source with Breadcrumbs, it will change the property type to "multitext" in the types.json every time the plugin is loaded (e.g when the Vault is opened).
This is frustrating if you want to keep a property as a different type, as you then have to change it back every time you open Obsidian.

My use case is that I want the property "prev" to always only contain a link to a single previous file, so I want to use the property type "text" for it. However every time I open Obsidian and this is reset, I need to manually change the property type back.

To Reproduce

Steps to reproduce the behavior:

  1. Add a property field that is an edge source in breadcrumbs (e.g "prev") to a note.
  2. Change the property type of "prev" to "text".
  3. Add a link in the property field.
  4. Close Obsidian and open it again.
  5. The property field will have been set back to "multitext".

Expected behavior

Breadcrumbs shouldn't overwrite how the user set their property types.

Suggestion

Breadcrumbs should check the properties, to see if a property already has a specified type, and if it does, not do anything with it. If a property doesn't have a specified type yet, it can go ahead and add it.

Desktop (please complete the following information):

  • OS: Tested on iOS (18.2) and MacOS (18.1)
  • Breadcrumbs version: The latest V4 version at the time of writing
  • Obsidian version: v1.7.5
@Signynt Signynt added the bug Something isn't working label Nov 11, 2024
@Signynt
Copy link
Author

Signynt commented Nov 11, 2024

I've gone ahead and created a PR which solves this issue: #581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant