fix for Miri and add Miri to CI #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feel free to ping me if you are still running into problems. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes running the fast path allocation function in Miri. The issue with the old function is that it implicitly calls
Vec::deref_mut, which creates a mutable slice covering all elements of the vector -- so if there are other pointers into that vector, they are now invalid, because the slice must be a unique pointer. The fix is to avoidVec::deref_mut.This is an instance of rust-lang/unsafe-code-guidelines#133: the mutable reference (for the slice) is created but never used, and still Stacked Borrows requires it to be unique. See that issue for further details.
This also sets up CI to run Miri. I hope I got that right.