Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in chatette.parsing.utils #27

Closed
IngerMathilde opened this issue Nov 13, 2019 · 2 comments
Closed

Bug in chatette.parsing.utils #27

IngerMathilde opened this issue Nov 13, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@IngerMathilde
Copy link

First of all really nice library! I did however notice a small bug in the chatette.parsing.utils file

On line 49-56 it states the following:
escapable_chars = [
ESCAPEMENT_SYM,
COMMENT_SYM, OLD_COMMENT_SYM,
UNIT_START_SYM, UNIT_START_SYM,
RAND_GEN_SYM, RAND_GEN_PERCENT_SYM,
VARIATION_SYM,
ARG_SYM,
CASE_GEN_SYM,
]

However, line 52 repeats UNIT_START_SYM, UNIT_START_SYM twice. Instead it the second instance should be replaced with UNIT_END_SYM.

Thus it should be
escapable_chars = [
ESCAPEMENT_SYM,
COMMENT_SYM, OLD_COMMENT_SYM,
UNIT_START_SYM, UNIT_END_SYM,
RAND_GEN_SYM, RAND_GEN_PERCENT_SYM,
VARIATION_SYM,
ARG_SYM,
CASE_GEN_SYM,
]

@SimGus
Copy link
Owner

SimGus commented Nov 13, 2019

Hello,

Thanks a lot for this very precise bug report :)
I'm fixing this right away. I'll also turn that list into a set, as it is never iterated over.

@SimGus SimGus added bug Something isn't working in progress This issue is being worked on labels Nov 13, 2019
@SimGus SimGus removed the in progress This issue is being worked on label Nov 13, 2019
@SimGus
Copy link
Owner

SimGus commented Nov 13, 2019

This is fixed on dev branch and will be included in the next release.

Thanks again for the heads up!

@SimGus SimGus closed this as completed in bad7739 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants