Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named random generation modifiers not working properly #19

Closed
DevinTDHa opened this issue Jul 3, 2019 · 4 comments
Closed

Named random generation modifiers not working properly #19

DevinTDHa opened this issue Jul 3, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@DevinTDHa
Copy link

Hello,

I am encountering an issue with Chatette v1.5.0 PyPI (installed via pip).

Rule: I don't like [world?WWII] war[ II?WWII].

Expected examples:

  • I don't like war.
  • I don't like world war II.

Generated examples:

  • I don't like war.
  • I don't like war II.
  • I don't like world war.
  • I don't like world war II.

I tested it with a .chatette file and the interactive console. Both methods generate the same sentences.

@SimGus
Copy link
Owner

SimGus commented Jul 3, 2019

There is indeed a bug. I'll try to fix that as soon as possible.

Thanks for the heads up :)

@SimGus SimGus added the bug Something isn't working label Jul 3, 2019
@SimGus
Copy link
Owner

SimGus commented Jul 3, 2019

I can see why this problem is occurring. However, this would need quite a lot of changes on the problematic code, and since I am in the middle of a refactor of this code, I will not fix it right now. This will be fixed as soon as the refactor is over (which I hope doesn't take too long).

@DevinTDHa
Copy link
Author

That's ok, good luck on the refactor!

@SimGus
Copy link
Owner

SimGus commented Sep 18, 2019

This is (finally) fixed in the latest version (v1.6.0) :)

@SimGus SimGus closed this as completed Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants