Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Node.js 12 runtime End-Of-Life (EOL) reached on April 30, 2022 #3710

Closed
8 tasks done
cindyorangis opened this issue Oct 14, 2022 · 3 comments
Closed
8 tasks done
Labels
type: bug Something isn't working

Comments

@cindyorangis
Copy link
Contributor

cindyorangis commented Oct 14, 2022

What happened:
Node.js 12 runtime has hit its End-Of-Life. This means it is no longer being maintained and does not receive critical bug fixes and security updates. The Active LTS is Node.js 16, so we should update our packages that specify the engine

-"node": ">=12"
+"node": ">=16"

Node.js 14 is in Maintenance, so we could update the following package.json as well:

What should have happened:
We should make sure our microservices runs as expected with Node.js 16. Most of our Dockerfiles already use node:16 or node:lts as its base so I don't think we need to make any changes there

Our CI tests also do not rely on Node.js 12 so we're good on that front as well.

How to reproduce it (as precise as possible):

Anything else we need to know?:

Environment:

  • OS:
  • Browser:
@cindyorangis cindyorangis added the type: bug Something isn't working label Oct 14, 2022
@AmasiaNalbandian
Copy link
Contributor

@cindyledev Did we get all of these? I think there's one points missing for package.json in root folder of Telescope right?

@HyperTHD
Copy link
Contributor

HyperTHD commented Nov 1, 2022

@cindyledev Did we get all of these? I think there's one points missing for package.json in root folder of Telescope right?

The root package.json is using node ver-14. To remain consistent, should also be upgraded too. Just my thought

@humphd
Copy link
Contributor

humphd commented Jan 20, 2023

Closing in favour of #3721.

@humphd humphd closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants