Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button][Enhancement] Allowing single button attached "buttons" group #5251

Closed
shanehsu opened this issue Apr 7, 2017 · 3 comments
Closed

Comments

@shanehsu
Copy link

shanehsu commented Apr 7, 2017

As of now (tested in 2.2.10 and 2.2.2), the ui bottom attached buttons doesn't behave well with one button as its child. While using ui bottom attached button would be good enough, my Angular application would have been a lot more complicated this way.

Suggestions:
The current code in bottom attached section:

.ui[class*="bottom attached"].buttons {
  margin-top: @attachedOffset;
  border-radius: 0em 0em @borderRadius @borderRadius;
}
.ui[class*="bottom attached"].buttons .button:first-child {
  border-radius: 0em 0em 0em @borderRadius;
}
.ui[class*="bottom attached"].buttons .button:last-child {
  border-radius: 0em 0em @borderRadius 0em;
}

Change to:

.ui[class*="bottom attached"].buttons {
  margin-top: @attachedOffset;
  border-radius: 0em 0em @borderRadius @borderRadius;
}
.ui[class*="bottom attached"].buttons .button:only-child {
  border-radius: 0em 0em @borderRadius @borderRadius;
}
.ui[class*="bottom attached"].buttons .button:first-child {
  border-radius: 0em 0em 0em @borderRadius;
}
.ui[class*="bottom attached"].buttons .button:last-child {
  border-radius: 0em 0em @borderRadius 0em;
}

The other three attached section will need this change as well if suggestion is accepted.

My knowledge of Semantic UI and LESS is not good enough for a PR, but this requires discussion anyway.

@shanehsu
Copy link
Author

@Banandrew Is this going to be implemented?

@awgv
Copy link
Member

awgv commented Oct 31, 2017

Hi @shanehsu, I don’t know, I’m not the maintainer.

@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@stale stale bot closed this as completed Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants