Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic semantic-ui examples #836

Closed
bali182 opened this issue Nov 11, 2016 · 16 comments
Closed

Basic semantic-ui examples #836

bali182 opened this issue Nov 11, 2016 · 16 comments

Comments

@bali182
Copy link

bali182 commented Nov 11, 2016

It would be very nice to have the basic sui examples ( http://semantic-ui.com/usage/layout.html ) using these components. It would be a really big help (even without any business logic).

@levithomason
Copy link
Member

levithomason commented Nov 11, 2016

Indeed, let's leave this one open. I'd like to add some examples. We get a lot of questions about CSS especially. I also think it would be good to add some minimal Webpack examples.

  • Port SUI Core layout examples
  • Basic Webpack project example
  • CDN CSS example
  • semantic-ui-css example

@bali182
Copy link
Author

bali182 commented Nov 11, 2016

I'm actively trying to recreate some of the samples, if I have some completely recreated, I'll make a PR

@iamcaleberic
Copy link
Contributor

@levithomason @bali182 would like to help with this

@levithomason
Copy link
Member

Awesome, PRs very much welcomed. I'd like to have the SUI core layout examples in the /docs app with a link in the docs sidebar. The rest of the examples are really full project examples, I'd like to add these to a new directory, /examples, with a sub directory for each.

@bali182
Copy link
Author

bali182 commented Dec 8, 2016

Sorry, I kinda forgot about this... I started recreating the login example, component names are spot on, everything was easy to find. However it doesn't really look like the original example:

https://gist.github.com/bali182/c05da546c2b16e74e5c8e9ca1ec3b613

148123190056399

I get the background, but the positioning is weird.

@iamcaleberic
Copy link
Contributor

@levithomason thanks for clarifying I'll keep working on it

@levithomason
Copy link
Member

@bali182 there is sometimes a small amount of override CSS applied to those examples. I'd inspect the elements and check their styling. It is likely that the original examples include some CSS that is not coming from the CSS framework.

@iamcaleberic
Copy link
Contributor

screenshot from 2016-12-14 16-36-52
@levithomason is the menu item for layouts correctly placed

https://github.com/iamcaleberic/Semantic-UI-React/tree/layout_examples

@levithomason
Copy link
Member

👍 Looks great

@iamcaleberic
Copy link
Contributor

@levithomason Do you want to add the layouts page after all the layouts are complete or i can make a pr for it thought it has placeholder links?

@levithomason
Copy link
Member

I'm a fan of rapid small steps. If you have even one layout working and the link, we can get that merged.

@iamcaleberic
Copy link
Contributor

@levithomason Alright no problem thanks

@levithomason
Copy link
Member

@iamcaleberic would you like to open a PR with what you have so far and we can get it merged?

@bobbyz-dk
Copy link

Would be very, very nice with an example of using semantic-ui-css. If someone could get me started I would love to help with it.

@iamcaleberic
Copy link
Contributor

iamcaleberic commented Jan 12, 2017

@bobbyz-dk to start you off you can checkout my page in the iamcaleberic.github.io/app/src/App.js folder check the import of semantic css. Alternatively you can the add the cdn for semantic-ui-css in your root index file

@iamcaleberic
Copy link
Contributor

@levithomason having a bit of an issue with the view source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants