Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples with images in React Docs are broken due to protocol change #1441

Closed
tyusupov opened this issue Mar 11, 2017 · 3 comments
Closed

Examples with images in React Docs are broken due to protocol change #1441

tyusupov opened this issue Mar 11, 2017 · 3 comments
Labels

Comments

@tyusupov
Copy link

Likely due to DNS changes several days ago, all examples in docs with image references that use http urls are broken.

For example, here's the code from Reveal Fade example from http://react.semantic-ui.com/elements/reveal

const RevealExampleFade = () => (
  <Reveal animated='fade'>
    <Reveal.Content visible>
      <Image src='http://semantic-ui.com/images/wireframe/square-image.png' size='small' />
    </Reveal.Content>
    <Reveal.Content hidden>
      <Image src='http://semantic-ui.com/images/avatar/large/ade.jpg' size='small' />
    </Reveal.Content>
  </Reveal>
)

Changing reference to https fixes the issue.

@levithomason
Copy link
Member

Thanks! We actually have all images here locally at /assets/images. I've updated all the doc examples and they are live now.

@tyusupov
Copy link
Author

Thanks a lot for a quick fix!

@tyusupov
Copy link
Author

Just noticed that some of the images are still not showing up, it seems to be that avatars in this directory are 404:

/assets/images/avatar2

Example can be found here: http://react.semantic-ui.com/collections/table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants