Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Segment): loading with clearing does not show the icon #1384

Closed
rkosafo opened this issue Feb 24, 2017 · 1 comment
Closed

fix(Segment): loading with clearing does not show the icon #1384

rkosafo opened this issue Feb 24, 2017 · 1 comment

Comments

@rkosafo
Copy link

rkosafo commented Feb 24, 2017

Steps to Reproduce

  1. Using the segment sample with loading
  2. Add clearing

Expected
The Segment should show the loading icon

Result
The Segment does not show the loading icon

Testcase
If the docs show the issue, use: http://react.semantic-ui.com/elements/segment
Otherwise, fork this to get started: http://codepen.io/levithomason/pen/ZpBaJX

import React from 'react'
import { Image, Segment } from 'semantic-ui-react'

const SegmentExampleLoading = () => (
  <Segment loading clearing>
    <Image src='http://semantic-ui.com/images/wireframe/paragraph.png' />
  </Segment>
)

export default SegmentExampleLoading
@levithomason
Copy link
Member

This seems sane to me, however, this is a CSS issue and this repo only deals with React components. The CSS for SUI is here: https://github.com/Semantic-Org/Semantic-UI.

A workaround is to manually place a loader within the Segment:

http://react.semantic-ui.com/elements/loader

import React from 'react'
import { Dimmer, Image, Loader, Segment } from 'semantic-ui-react'

const SegmentExampleLoading = () => (
  <Segment clearing>
    <Dimmer active inverted>
      <Loader inverted />
    </Dimmer>

    <Image src='http://semantic-ui.com/images/wireframe/paragraph.png' />
  </Segment>
)

export default SegmentExampleLoading

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants