Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: .NET: Support nullable reference types #14640

Open
5 of 22 tasks
RenderMichael opened this issue Oct 24, 2024 · 9 comments
Open
5 of 22 tasks

[🚀 Feature]: .NET: Support nullable reference types #14640

RenderMichael opened this issue Oct 24, 2024 · 9 comments

Comments

@RenderMichael
Copy link
Contributor

RenderMichael commented Oct 24, 2024

Feature and motivation

Annotate the code for nullable reference type support. This would be massively beneficial for clarity and to prevent null reference exceptions, both within Selenium and for users.

Usage example

image
image

Affected namespaces

  • OpenQA.Selenium
  • OpenQA.Selenium.BiDi
  • OpenQA.Selenium.BiDi.Communication
    • Nested namespaces
  • OpenQA.Selenium.BiDi.Modules
    • Nested namespaces
  • OpenQA.Selenium.Chrome
  • OpenQA.Selenium.Chromium
  • OpenQA.Selenium.DevTools
    • Nested namespaces
  • OpenQA.Selenium.Edge
  • OpenQA.Selenium.Firefox
  • OpenQA.Selenium.Firefox.Internal
  • OpenQA.Selenium.IE
  • OpenQA.Selenium.Interactions
  • OpenQA.Selenium.Interactions.Internal
  • OpenQA.Selenium.Internal
  • OpenQA.Selenium.Internal.Logging
  • OpenQA.Selenium.Remote
  • OpenQA.Selenium.Safari
  • OpenQA.Selenium.Support.UI
  • OpenQA.Selenium.VirtualAuth
Copy link

@RenderMichael, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@RenderMichael
Copy link
Contributor Author

If Selenium is interested in accepting NRT, I'll gladly take up the task

@nvborisenko
Copy link
Member

It would be great, and it would be challenging as for you as for us :) Only one request: try keeping PRs small.

@nvborisenko
Copy link
Member

@RenderMichael do you mind to join Selenium Slack channel for messaging instantly?

@nvborisenko
Copy link
Member

Hi Michael, do you think it makes sense to create something to track how far we are from final goal? Probably simple list by namespaces how many warnings we had/have.

@RenderMichael
Copy link
Contributor Author

I can make a list by namespace, but the PRs will likely not be one-to-one with this list. Still, a good heuristic.

@nvborisenko
Copy link
Member

Not even mention PRs, something like?:

  • Selenium.Firefox 14 left out 20
  • Selenium.Chrome.Something 2 left out of 40

where in case of Firefox: 20 how many warnings we had before (at the beginning of this journey), and 14 how many we have at this time. This list is editable by you (in your original post?).

Just to understand where we are.

@RenderMichael
Copy link
Contributor Author

I made a checkbox list of namespaces, and I'll populate the list with values as I test things out.

@nvborisenko
Copy link
Member

Thank you so much, it will help us to measure our power and abilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants