-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🚀 Feature]: .NET: Support nullable reference types #14640
Comments
@RenderMichael, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
If Selenium is interested in accepting NRT, I'll gladly take up the task |
It would be great, and it would be challenging as for you as for us :) Only one request: try keeping PRs small. |
@RenderMichael do you mind to join Selenium Slack channel for messaging instantly? |
Hi Michael, do you think it makes sense to create something to track how far we are from final goal? Probably simple list by namespaces how many warnings we had/have. |
I can make a list by namespace, but the PRs will likely not be one-to-one with this list. Still, a good heuristic. |
Not even mention PRs, something like?:
where in case of Firefox: Just to understand where we are. |
I made a checkbox list of namespaces, and I'll populate the list with values as I test things out. |
Thank you so much, it will help us to measure our power and abilities. |
Feature and motivation
Annotate the code for nullable reference type support. This would be massively beneficial for clarity and to prevent null reference exceptions, both within Selenium and for users.
Usage example
Affected namespaces
OpenQA.Selenium
OpenQA.Selenium.BiDi
OpenQA.Selenium.BiDi.Communication
OpenQA.Selenium.BiDi.Modules
OpenQA.Selenium.Chrome
OpenQA.Selenium.Chromium
OpenQA.Selenium.DevTools
OpenQA.Selenium.Edge
OpenQA.Selenium.Firefox
OpenQA.Selenium.Firefox.Internal
OpenQA.Selenium.IE
OpenQA.Selenium.Interactions
OpenQA.Selenium.Interactions.Internal
OpenQA.Selenium.Internal
OpenQA.Selenium.Internal.Logging
OpenQA.Selenium.Remote
OpenQA.Selenium.Safari
OpenQA.Selenium.Support.UI
OpenQA.Selenium.VirtualAuth
The text was updated successfully, but these errors were encountered: